New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write CoreV1ReplicationController lifecycle test+promote - +7 coverage #88302
Comments
Deployment replaced ReplicationController a while back. We need to check more than the data-aspect (beyond crud), we need to verify the data-plane. In this case we need to check the pods as well and not just the ReplicationController status. Moved to backlog by conformance subgroup. |
PR: #88588 |
/open We need this open to track the test promotion and flakyness. |
@hh: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retitle Promote CoreV1ReplicationController lifecycle mock test - +7 coverage |
/retitle Write CoreV1ReplicationController lifecycle test+promote - +7 coverage |
Closing in favour of #90881 |
@hh: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Identify an untested feature Using APISnoop
According to this APIsnoop query, there are still some remaining ReplicationController endpoints which are untested.
Use API Reference to Lightly Document the Feature
The mock test
Test outline
Create a ReplicationController with a static label
Patch the ReplicationController with a new Label and updated data
Patch the ReplicationController's status
Patch/Scale the ReplicationController's Replica count to 2 Replicas
Get the ReplicationController
Replace the ReplicationController's Status
List all ReplicationControllers in all Namespaces find the ReplicationControllers(1) ensure that the ReplicationController is found and is patched
Delete Namespaced ReplicationControllers(1) via a Collection with a LabelSelector
Example in Go
Verify Increase it Coverage with APISnoop
Discover useragents:
See all endpoints hit from this test
Display test coverage change
Final notes
If a test with these calls gets merged, test coverage will go up by 7 points
This test is also created with the goal of conformance promotion.
/sig testing
/sig architecture
/area conformance
The text was updated successfully, but these errors were encountered: