Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated ExternalID #61966

Closed
mikedanese opened this issue Mar 31, 2018 · 1 comment · Fixed by #61877
Closed

remove deprecated ExternalID #61966

mikedanese opened this issue Mar 31, 2018 · 1 comment · Fixed by #61877
Assignees
@mikedanese
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@mikedanese
Copy link
Member

/sig node
/sig cloud
@mikedanese mikedanese self-assigned this Mar 31, 2018
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Mar 31, 2018
@mikedanese mikedanese mentioned this issue Mar 31, 2018
Merged
@mikedanese
Copy link
Member Author

ExternalID aliased to InstanceID

  • azure
  • cloudstack
  • vsphere

ovirt InstanceID is ExternalID with a leading '/'

photon InstanceID and ExternalID are copies of the same function

gce InstanceID is <project>/<zone>/<instance> and ExternalID is <instance>

aws InstanceID is /<zone>/<instance> and ExternalID is <instance>

k8s-github-robot pushed a commit that referenced this issue Apr 19, 2018
Merge pull request #61877 from mikedanese/depeid
efadf7b 
Automatic merge from submit-queue (batch tested with PRs 62481, 62643, 61877, 62515). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

remove deprecated ExternalID

This field has been deprecated since 1.1. After we remove it we can remove "self delete" from the node's permission set.

@kubernetes/api-reviewers 
@kubernetes/sig-auth-pr-reviews 

fixes #61966
part of kubernetes/community#911

```release-note
Kubelets will no longer set `externalID` in their node spec.
```
k8s-publishing-bot added a commit to kubernetes/api that referenced this issue Apr 19, 2018
@k8s-publishing-bot
Merge pull request #61877 from mikedanese/depeid
2b3d59d 
Automatic merge from submit-queue (batch tested with PRs 62481, 62643, 61877, 62515). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

remove deprecated ExternalID

This field has been deprecated since 1.1. After we remove it we can remove "self delete" from the node's permission set.

@kubernetes/api-reviewers
@kubernetes/sig-auth-pr-reviews

fixes kubernetes/kubernetes#61966
part of kubernetes/community#911

```release-note
Kubelets will no longer set `externalID` in their node spec.
```

Kubernetes-commit: efadf7b9e7101a5018524c47e8f7e5881d5f7e88
mahendrakariya added a commit to mahendrakariya/kubernetes that referenced this issue Sep 20, 2019
@mahendrakariya
Remove deprecated field
75e9bfc 
DoNotUse_ExternalID has been deprecated and is not in use anymore.
It has been removed to fix lint errors related to underscores in field
names.

Ref kubernetes#68026, kubernetes#61966
k8s-ci-robot pushed a commit that referenced this issue Sep 25, 2019
@mahendrakariya @k8s-ci-robot
Fix golint errors in pkg/apis/core (#82919)
3698100 
* Fix lint errors related to receiver name

Ref #68026

* Fix lint errors related to comments

Ref #68026

* Fix package name in comments

Ref #68026

* Rename Cpu to CPU

Ref #68026

* Fix lint errors related to naming convention

Ref #68026

* Remove deprecated field

DoNotUse_ExternalID has been deprecated and is not in use anymore.
It has been removed to fix lint errors related to underscores in field
names.

Ref #68026, #61966

* Include pkg/apis/core in golint check

Ref #68026

* Rename var to fix lint errors

Ref #68026

* Revert "Remove deprecated field"

This reverts commit 75e9bfc.

Ref #82919

* Remove math from godoc

Ref #82919, #68026

* Remove underscore from var name

Ref #68026

* Rename var in staging core api type

Ref #68026
@SataQiu SataQiu mentioned this issue Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikedanese mikedanese

Labels
sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove deprecated ExternalID mikedanese/kubernetes
2 participants
@mikedanese @k8s-ci-robot