Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --docker-disable-shared-pid from kubelet #41938

Closed
verb opened this issue Feb 23, 2017 · 7 comments · Fixed by #66506
Closed

Remove --docker-disable-shared-pid from kubelet #41938

verb opened this issue Feb 23, 2017 · 7 comments · Fixed by #66506
Assignees
@verb
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@verb
Copy link
Contributor

verb commented Feb 23, 2017 •
edited

Rather than making process namespace sharing the default for all pods we will make it configurable per-pod in the API as described in kubernetes/community#1048. The --docker-disable-shared-pid flag will be removed from the kubelet in favor of a new field in v1.Pod.

This issue tracks removing this flag once it's no longer used.
@verb verb mentioned this issue Feb 23, 2017
Merged
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 31, 2017
@xiangpengzhao
Copy link
Contributor

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 17, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 17, 2017
@verb verb mentioned this issue Aug 30, 2017
Closed
@verb
Copy link
Contributor Author

verb commented Sep 12, 2017

/assign @verb

likely to be addressed in 1.9

@dustymabe dustymabe mentioned this issue Dec 11, 2017
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2018
@verb
Copy link
Contributor Author

verb commented Jan 6, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2018
@verb verb mentioned this issue Jan 10, 2018
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2018
@verb
Copy link
Contributor Author

verb commented Apr 12, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 12, 2018
@verb verb mentioned this issue May 7, 2018
Closed
@verb
Copy link
Contributor Author

verb commented May 7, 2018

FYI, right now we're planning on including this in 1.12.

@verb verb mentioned this issue Jul 23, 2018
Merged
cblecker pushed a commit to cblecker/kubernetes that referenced this issue Jul 23, 2018
Merge pull request kubernetes#66506 from verb/remove-docker-pid-sharing
42d91ff 
Automatic merge from submit-queue (batch tested with PRs 62423, 66180, 66492, 66506, 65242). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove kubelet docker shared pid flag

**What this PR does / why we need it**:
The --docker-disable-shared-pid flag has been deprecated since 1.10 and
has been superceded by ShareProcessNamespace in the pod API, which is
scheduled for beta in 1.12.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes kubernetes#41938

**Special notes for your reviewer**:
/assign @yujuhong 

**Release note**:

```release-note
The --docker-disable-shared-pid kubelet flag has been removed. PID namespace sharing can instead be enable per-pod using the ShareProcessNamespace option.
```
damoon added a commit to utopia-planitia/kubernetes that referenced this issue Oct 4, 2018
@damoon
removed --docker-disable-shared-pid flag - kubernetes/kubernetes#41938
e7a7c0e
@guevara guevara mentioned this issue May 20, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verb verb

Labels
sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove kubelet docker shared pid flag verb/kubernetes
5 participants
@verb @k8s-github-robot @xiangpengzhao @k8s-ci-robot @fejta-bot